Fix XPathFromCSS bug(general) & test case compile error(xcode 7)#41
Fix XPathFromCSS bug(general) & test case compile error(xcode 7)#41cezheng wants to merge 2 commits intomattt:masterfrom
Conversation
NSArray implementation is changed in Xcode 7 making it possible to specify type info for its elements. Old style NSArray element might fail to compile by send a selector like "tag"(which exists in many UIKit classes). Please refer to 'Objective-C Language Features' in http://adcdownload.apple.com/Developer_Tools/Xcode_7_beta_4/Xcode_7_beta_4_Release_Notes.pdf
|
It turns out that more bugs are found with Ono that I fixed in my Swift port. So closing this PR for now. |
|
Apologies for being away for so long. I appreciate that you took the initiative to port Ono into Swift in my absence, and thank you for your work on this an other contributions. I cherry-picked 002d2f2 into master. The changes in 94f30a5 were applied previously by a different commit. You mentioned that you found additional bugs that you fixed in your Swift port. If you happen to recall what they are, I'd be very happy to address them in this project as well. |
|
Welcome back. It's been a long time, so I might have missed some of them:
|
|
Thanks for the swifty fix:) But I think you also need one in |
|
Nice catch :) Fixed by 05cb155. Thanks again! |
002d2f2
Fixed a bug in XPathFromCSS that mistakenly matches the CSS string rather than token string, test case added for this bug.
94f30a5
Added explicit type cast to fix compilation error for test in Xcode 7 beta, where NSArray returns ObjectType element rather than id. This will not affect previous versions of Xcode. Please refer to 'Objective-C Language Features' in http://adcdownload.apple.com/Developer_Tools/Xcode_7_beta_4/Xcode_7_beta_4_Release_Notes.pdf