Skip to content

Fix XPathFromCSS bug(general) & test case compile error(xcode 7)#41

Closed
cezheng wants to merge 2 commits intomattt:masterfrom
cezheng:fix/css2xpath_bug_and_test_case_compile_error_in_xcode_7
Closed

Fix XPathFromCSS bug(general) & test case compile error(xcode 7)#41
cezheng wants to merge 2 commits intomattt:masterfrom
cezheng:fix/css2xpath_bug_and_test_case_compile_error_in_xcode_7

Conversation

@cezheng
Copy link
Contributor

@cezheng cezheng commented Aug 2, 2015

002d2f2
Fixed a bug in XPathFromCSS that mistakenly matches the CSS string rather than token string, test case added for this bug.

94f30a5
Added explicit type cast to fix compilation error for test in Xcode 7 beta, where NSArray returns ObjectType element rather than id. This will not affect previous versions of Xcode. Please refer to 'Objective-C Language Features' in http://adcdownload.apple.com/Developer_Tools/Xcode_7_beta_4/Xcode_7_beta_4_Release_Notes.pdf

cezheng added 2 commits August 2, 2015 13:43
NSArray implementation is changed in Xcode 7 making it possible to
specify type info for its elements. Old style NSArray element might fail
to compile by send a selector like "tag"(which exists in many UIKit
classes).
Please refer to 'Objective-C Language Features' in http://adcdownload.apple.com/Developer_Tools/Xcode_7_beta_4/Xcode_7_beta_4_Release_Notes.pdf
@cezheng cezheng changed the title Fix XPathFromCSS bug and test case compile error in xcode 7 Fix XPathFromCSS bug(general) & test case compile error(xcode 7) Aug 2, 2015
@cezheng
Copy link
Contributor Author

cezheng commented Sep 26, 2015

It turns out that more bugs are found with Ono that I fixed in my Swift port. So closing this PR for now.

@cezheng cezheng closed this Sep 26, 2015
@mattt mattt reopened this Mar 21, 2018
@mattt
Copy link
Owner

mattt commented Mar 21, 2018

Apologies for being away for so long. I appreciate that you took the initiative to port Ono into Swift in my absence, and thank you for your work on this an other contributions.

I cherry-picked 002d2f2 into master. The changes in 94f30a5 were applied previously by a different commit.

You mentioned that you found additional bugs that you fixed in your Swift port. If you happen to recall what they are, I'd be very happy to address them in this project as well.

@cezheng
Copy link
Contributor Author

cezheng commented Mar 22, 2018

Welcome back.

It's been a long time, so I might have missed some of them:

@mattt
Copy link
Owner

mattt commented Mar 22, 2018

Thanks for following up, @cezheng. It's good to be back.

I just added the missing call to xmlResetLastError() in the document initializer with e428e06. If you remember any other bugs that you fixed, please let me know. Thanks again!

@cezheng
Copy link
Contributor Author

cezheng commented Mar 22, 2018

Thanks for the swifty fix:) But I think you also need one in HTMLDocumentWithData;)

@mattt
Copy link
Owner

mattt commented Mar 22, 2018

Nice catch :)

Fixed by 05cb155. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants