[NIFI-9667] Initial UPDATE configuration via C2#21
Merged
mattyb149 merged 5 commits intomattyb149:NIFI-9666from May 13, 2022
Merged
Conversation
bejancsaba
commented
May 12, 2022
| } | ||
| } | ||
|
|
||
| public void startChangeNotifier() { |
Collaborator
Author
There was a problem hiding this comment.
This is just a temporary solution to make this PR work the proper solution will come later in another PR.
bejancsaba
commented
May 12, 2022
| } | ||
| } | ||
|
|
||
| Optional.ofNullable(bootstrapProperties) |
Collaborator
Author
There was a problem hiding this comment.
This is the code that is borrowed from @ferencerdei 's upcoming PR
bejancsaba
commented
May 12, 2022
| return processGroupStatus; | ||
| } | ||
|
|
||
| private boolean updateFlowContent(ByteBuffer updateContent) { |
Collaborator
Author
There was a problem hiding this comment.
For now this is the file write + restart approach. As it is not final and we will go with flowController / flowService based reload I tried to keep it as simple as possible.
bejancsaba
force-pushed
the
NIFI-9667-Update-Configuration-via-c2-client
branch
from
c164815 to
d1ff8e5
Compare
mattyb149
reviewed
May 13, 2022
|
|
||
| private static final Logger logger = LoggerFactory.getLogger(C2Properties.class); | ||
|
|
||
| public static final String NIFI_PREFIX = "nifi."; |
Owner
There was a problem hiding this comment.
I'm wondering if we need the nifi prefix here, since it's in the c2 module and not technically NiFi-specific. If that would cause too many issues downstream, I'm ok with leaving it in.
Collaborator
Author
There was a problem hiding this comment.
I agree, removed the nifi prefix as at the c2 level it has "no meaning". To run it you need to remove the nifi. prefixes in the bootstrap conf example I added to this pr
mattyb149
added a commit
that referenced
this pull request
May 17, 2022
* NIFI-9666: Initial commit of C2 client implementation * [NIFI-9667] Initial UPDATE configuration via C2 * [NIFI-9667] Rebase to latest NIFI-9666 * [NIFI-9667] Module cleanup * [NIFI-9667] Addressing PR comment removing nifi prefix from properties Co-authored-by: Matthew Burgess <mattyb149@apache.org>
mattyb149
added a commit
that referenced
this pull request
May 18, 2022
* NIFI-9666: Initial commit of C2 client implementation * [NIFI-9667] Initial UPDATE configuration via C2 * [NIFI-9667] Rebase to latest NIFI-9666 * [NIFI-9667] Module cleanup * [NIFI-9667] Addressing PR comment removing nifi prefix from properties Co-authored-by: Matthew Burgess <mattyb149@apache.org>
mattyb149
added a commit
that referenced
this pull request
May 20, 2022
* NIFI-9666: Initial commit of C2 client implementation * [NIFI-9667] Initial UPDATE configuration via C2 * [NIFI-9667] Rebase to latest NIFI-9666 * [NIFI-9667] Module cleanup * [NIFI-9667] Addressing PR comment removing nifi prefix from properties Co-authored-by: Matthew Burgess <mattyb149@apache.org>
mattyb149
added a commit
that referenced
this pull request
May 23, 2022
* NIFI-9666: Initial commit of C2 client implementation * [NIFI-9667] Initial UPDATE configuration via C2 * [NIFI-9667] Rebase to latest NIFI-9666 * [NIFI-9667] Module cleanup * [NIFI-9667] Addressing PR comment removing nifi prefix from properties Co-authored-by: Matthew Burgess <mattyb149@apache.org>
mattyb149
added a commit
that referenced
this pull request
May 24, 2022
[NIFI-9667] Initial UPDATE configuration via C2 (#21) * NIFI-9666: Initial commit of C2 client implementation * [NIFI-9667] Initial UPDATE configuration via C2 * [NIFI-9667] Rebase to latest NIFI-9666 * [NIFI-9667] Module cleanup * [NIFI-9667] Addressing PR comment removing nifi prefix from properties Co-authored-by: Matthew Burgess <mattyb149@apache.org>
mattyb149
added a commit
that referenced
this pull request
May 26, 2022
[NIFI-9667] Initial UPDATE configuration via C2 (#21) * NIFI-9666: Initial commit of C2 client implementation * [NIFI-9667] Initial UPDATE configuration via C2 * [NIFI-9667] Rebase to latest NIFI-9666 * [NIFI-9667] Module cleanup * [NIFI-9667] Addressing PR comment removing nifi prefix from properties Co-authored-by: Matthew Burgess <mattyb149@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: There were / are a few things that needs to be addressed:
If you want to try it a reference bootstrap configuration:
nifi.minifi.notifier.ingestors=org.apache.nifi.minifi.bootstrap.configuration.ingestors.FileChangeIngestor
nifi.minifi.notifier.ingestors.file.config.path=./conf/config-new.yml
nifi.minifi.notifier.ingestors.file.polling.period.seconds=5
nifi.c2.enable=true
nifi.c2.config.directory=./conf
nifi.c2.runtime.manifest.identifier=minifi
nifi.c2.runtime.type=minifi-java
nifi.c2.rest.url=http://localhost:10090/efm/api/c2-protocol/heartbeat
nifi.c2.rest.url.ack=http://localhost:10090/efm/api/c2-protocol/acknowledge
nifi.c2.agent.heartbeat.period=5000
nifi.c2.agent.identifier=123-456-789
nifi.c2.agent.class=java-new