Closed
Conversation
Contributor
cgzones
commented
Apr 1, 2025
cgzones
commented
- Support magnitude suffixes
- Separate multiple human readable sections with comma
- Reject expiration sets with duplicate duration values
- Change month from 28 to 30 days
- Change year from 336 to 365 days
matze
requested changes
May 18, 2025
Owner
matze
left a comment
matze
left a comment
There was a problem hiding this comment.
Two things:
- this should be documented in the README.md and the CHANGELOG.md.
- is this compatible with 3.0.0 behaviour?
Owner
|
Could you rebase on top of master? I also already added an improved |
* Support magnitude suffixes * Separate multiple human readable sections with comma * Reject expiration sets with duplicate duration values * Change month from 28 to 30 days * Change year from 336 to 365 days
matze
requested changes
May 25, 2025
| write!(f, "{years} years")?; | ||
| } else { | ||
| parts.push(String::from("1 year")); | ||
| write!(f, "1 year")?; |
Owner
There was a problem hiding this comment.
Could you please drop these changes. The join in the original code already inserts separators.
Owner
|
I split the changes into individual commits and also added relevant CHANGELOG.md and README.md documentation. Hope that's fine. You are still attributed as commit author. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.