Set color-scheme: dark for dark theme#164
Conversation
|
|
|
aaah this breaks light theme, let me fix that first... |
luk1337
force-pushed
the
luk/color_scheme_dark
branch
from
5d1b1e3 to
db8c4c7
Compare
fixed. |
matze
left a comment
matze
left a comment
There was a problem hiding this comment.
Doesn't that break browser settings if not overridden by the user? You can clear cookies and check with the bruiser inspector tools.
seems alright here? my phone's dark theme setting is respected when I open the page in incognito mode. |
|
I will check later tonight when I have some time and laptop access. Thanks already! |
|
also, switching prefers-color-scheme in dev tools seems alright too:
|
matze
left a comment
matze
left a comment
There was a problem hiding this comment.
If you want also add a CHANGELOG.md entry, otherwise I will do it post merge.
Makes scrollbars dark ^.^
luk1337
force-pushed
the
luk/color_scheme_dark
branch
from
db8c4c7 to
59f965c
Compare
|
|
||
| - Use main accent color for selected options. | ||
| - Root element's `color-scheme` is now set according to the selected theme, which | ||
| makes browser use appropriate color scheme for its UI. |
2 participants
Makes scrollbars dark ^.^