Conversation
matze
left a comment
There was a problem hiding this comment.
Thank you very much for going the long way and introducing Catppuccin everywhere along the dependency tree. I like the change but would only merge with a release of two-face and light theme being supported.
But again, much appreciated!
|
Thank you for the fast reply! I'll put this pr into draft until two-face creates a new release. Have a great day! |
|
@CosmicHorrorDev any ETA on a new release? |
|
|
Yup yup. And doubly so in this case because adding/removing themes is currently a breaking change with |
|
That being said the breaking changes are already merged, so I could cut a |
Definitely an option for me. The git dependency right now, is a pain in the ass 😅 |
|
Consider it done after I'm off work o7 |
|
Thank you both for you work and help! I can update the Cargo.toml file tomorrow and mark this pr as ready. Have a great day! |
|
and |
|
Hello, I've rebased this pr and it should be ready now. Have a great day! |
|
You might want to format with |
Hello!
I worked myself down from creating a catppuccin submodule of their bat theme, merging this into bat, adding the catppuccin themes to two-face and now I'm here.
I've added the Catppuccin Mocha theme as "catppuccin".
two-face hasn't made a release since they merged my pr, so I bumped the dependency to their git version.
If you want to wait for the release instead, I can put this into draft until two-face and bat are ready.
Have a great day!