Merged
Conversation
matze
requested changes
Sep 23, 2024
Owner
matze
left a comment
matze
left a comment
There was a problem hiding this comment.
Please add a CHANGELOG.md entry and mark it as a breaking change.
Make clear to readers that the value 0 is not supported and has no special meaning. Also allows the compiler to improve enum layouts.
Contributor
Author
Added a Changelog entry, restored the possibility to explicitly specify |
matze
approved these changes
Sep 30, 2024
Owner
|
Thanks for this as well 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make clear to readers that the value 0 is not supported and has no special meaning.
Also allows the compiler to improve enum layouts.