Merged
Conversation
Especially useful on mobile without key input.
Some tests to ensure stable behavior for refactoring.
matze
reviewed
Nov 5, 2024
Owner
matze
left a comment
matze
left a comment
There was a problem hiding this comment.
Just some questions, looks good in general. Thanks!
matze
reviewed
Nov 7, 2024
Set same-iste, secure (if https is used) and http-only flags.
Inform browsers about about to be used resources.
Requested by browsers on back operation.
Reported by validator.w3.org
Reported by validator.w3.org
Reported by validator.w3.org
Reported by validator.w3.org
Avoid logs with severity error if a client passes a wrong password.
The max_expiration setting is not going to change at runtime.
The string
entity.name - (entity.name.section | entity.name.tag | entity.name.label)
gets translated into the invalid CSS selector
.entity.name, .entity.name.tag, .entity.name.label)
Reported by jigsaw.w3.org/css-validator/
matze
reviewed
Nov 10, 2024
Owner
|
Thanks for the efforts! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits for more details.