Document campaign_event_cache_ttl configuration parameter#710
Conversation
promptless-for-oss
requested review from
adiati98 and
favour-chibueze
and removed request for
a team
|
@promptless-for-oss please rebase to 7.2 branch |
Add documentation for the new campaign_event_cache_ttl parameter from mautic/mautic PR #16110, which allows administrators to configure how long Campaign event statistics are cached before refreshing from the database. Also document the related campaign_contact_count_cache_ttl parameter for completeness. These settings are configured via config/local.php and help balance UI responsiveness against database load on high-volume instances.
promptless-for-oss
force-pushed
the
promptless/campaign-event-cache-ttl
branch
from
29a4e28 to
9da75b2
Compare
|
Done! I've rebased this PR to target the 7.2 branch as requested. The branch has been rebased and the PR base has been updated. |
adiati98
left a comment
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions
Address reviewer suggestions: - Add vale off/on around heading - Use backticks instead of bold for parameter names - Rephrase defaults with "which is X" format - Add "you can" to config instruction - Fix RST indentation in code blocks and notes
|
Thanks for the detailed review, @adiati98! I've applied all your suggestions:
Ready for re-review. |
Address reviewer feedback to remove passive voice "is enabled".
|
Thanks for the feedback! I've updated the documentation to use active voice as requested. Change made:
The branch has been updated with this change. |
Address PR review feedback: changed "requires" to "must enable" to clarify that the TTL setting is conditional rather than a hard dependency. The setting is silently ignored if caching is not active, rather than causing errors.
|
Thanks for the feedback @adiati98! I've updated the wording to clarify that Doctrine caching is a conditional feature rather than a hard dependency — the TTL setting is silently ignored if caching isn't active, not a requirement that would cause errors. The change is now pushed to this branch. |
|
@adiati98 The 'campaign_contact_count_cache_ttl' => 43200, // 12 hours in secondsThis was already present in the codebase before PR #16110, which added the new |
Per reviewer feedback, clarified: - "increase database queries" → "increase the number of database queries" - "delay when new executions appear" → "delay the appearance of new executions"
|
Thanks for the feedback @adiati98! I've applied your suggested wording improvements—the updated text is now clearer about "the number of database queries" and "the appearance of new executions." |
3 participants
Open this suggestion in Promptless to view citations and reasoning process
Documents the new campaign_event_cache_ttl parameter from PR mautic/mautic#16110, which allows administrators to configure caching for Campaign event statistics in the UI. Also documents the related campaign_contact_count_cache_ttl parameter for completeness.
Trigger Events
Tip: Worried about broken links? Ask Promptless to find and fix them automatically 🔗