client: don't crash if we can't load cookies from the database#51
Merged
bradtgmurray merged 1 commit intomainfrom Feb 11, 2026
Merged
client: don't crash if we can't load cookies from the database#51bradtgmurray merged 1 commit intomainfrom
bradtgmurray merged 1 commit intomainfrom
Conversation
tulir
changed the title
tulir
approved these changes
Feb 11, 2026
bradtgmurray
added a commit
that referenced
this pull request
Feb 11, 2026
With #51, we worked around a crash at startup by handling our cookie jar being nil, but that just caused explosions down the line when we tried to do other operations such as logging out which would attempt to use our cookies (c.getCSRFToken refers to c.jar which is nil). https://github.com/mautrix/linkedin/blob/b4fddae12a26bb3241d67e2526df298a46656202/pkg/linkedingo/self.go#L57-L62 Just make sure our linkedingo.Client is never created with nil cookies. This also makes the previous change unecessary. Pushed IsLoggedIn down to the linkedingo client to make things more similar to our other bridges instead of checking the origina userLogin struct. Also, skip logging out if we're not logged in, there's no credentials available to make the logout request with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In October 2025 (77c78a7) we changed how cookies are stored and if you boot up a new bridge with the old format we'd end up with nil cookies due to an Unmarshalling failure. Treat us not having cookies as not being logged in instead of crashing.