Merged
Conversation
tulir
reviewed
Oct 7, 2020
Co-authored-by: Tulir Asokan <tulir@maunium.net>
tulir
reviewed
Oct 7, 2020
Co-authored-by: Tulir Asokan <tulir@maunium.net>
witchent
commented
Oct 7, 2020
| else: | ||
| return await self.az.intent.send_notice(self.room_id, message, html=html) | ||
|
|
||
| def mark_read(self) -> Awaitable[None]: |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| def mark_read(self) -> Awaitable[None]: | |
| async def mark_read(self) -> Awaitable[None]: |
Comment on lines
+148
to
+149
| if not self.is_portal: | ||
| return self.az.intent.mark_read(self.room_id, self.event_id) |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| if not self.is_portal: | |
| return self.az.intent.mark_read(self.room_id, self.event_id) | |
| if self.room_id in await self.az.intent.get_joined_rooms(): | |
| return self.az.intent.mark_read(self.room_id, self.event_id) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One should probably move the main_intent of the bridge to the event at some point to remove the async of reply, but it is working like this.