Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mavlink Dialect pixhawk does not exits anymore #452

Closed
devbharat opened this issue Dec 13, 2015 · 5 comments
Closed

Mavlink Dialect pixhawk does not exits anymore #452

devbharat opened this issue Dec 13, 2015 · 5 comments
Labels
feature request
Milestone
Version 0.17

Comments

@devbharat
Copy link
Contributor

Need to get rid of it from mavconn/mavlink_dialect.h and other places to avoid confusion.
@vooon
Copy link
Member

vooon commented Dec 13, 2015

What proffered: error or warning + fallback?

@vooon vooon added this to the Version 0.17 milestone Dec 13, 2015
@vooon
Copy link
Member

vooon commented Dec 13, 2015

Mavlink-gpb-release take care on providing known dialects. Cmake checks that correct setting set.

So mavlink_dialect.h not need to change.

@devbharat
Copy link
Contributor Author

If what was in pixhawk.XML was essentially the same as what we have in common.XML, the warning +fallback should be OK I guess.

@vooon
Copy link
Member

vooon commented Dec 13, 2015

I rechecked - warning not possible now. Only build error.

vooon added a commit that referenced this issue Dec 13, 2015
@vooon
libmavconn #452: remove pixhawk, add paparazzi dialects.
8c90c11 
Mavlink package provide information about known dialects,
so we do not touch mavlink_dialect.h selection ifs.
@vooon
Copy link
Member

vooon commented Dec 13, 2015

Fixed.

Note to users: if you has build error like that:

CMake Error at cmake/Modules/MavrosMavlink.cmake:27 (message):
  Unknown MAVLink dialect: pixhawk, known dialects:
  slugs;paparazzi;python_array_test;autoquad;ardupilotmega;test;ASLUAV;minimal;common;ualberta;matrixpilot
Call Stack (most recent call first):
  CMakeLists.txt:16 (include)

Then just use common dialect.

@vooon vooon closed this as completed Dec 13, 2015
nmichael pushed a commit to rislab/mavros that referenced this issue Mar 19, 2016
@LorenzMeier
Merge pull request mavlink#452 from hamishwillee/hamishwillee-improve…
11bcadc 
…-linking-to-fields

Update mavlink_to_html_table.xsl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
Version 0.17
Development

No branches or pull requests
2 participants
@vooon @devbharat