Skip to content

fix: give service access to fs#93

Merged
max-baz merged 1 commit intomax-baz:mainfrom
name-snrl:allow-wluma-update-state
Jan 26, 2024
Merged

fix: give service access to fs#93
max-baz merged 1 commit intomax-baz:mainfrom
name-snrl:allow-wluma-update-state

Conversation

@name-snrl
Copy link
Copy Markdown
Contributor

If PrivateNetwork is set, it also implicitly sets PrivateMounts to the value of true, in this patch we have explicitly set it to false.

related #92

If `PrivateNetwork` is set, it also implicitly sets `PrivateMounts` to
the value of `true`, in this patch we have explicitly set it to false.
@name-snrl name-snrl force-pushed the allow-wluma-update-state branch from 5f98539 to 4cc0e2e Compare January 26, 2024 05:05
@max-baz
Copy link
Copy Markdown
Owner

max-baz commented Jan 26, 2024

I was trying hard to reproduce the issue, or finding any difference with and without setting PrivateMounts to false, I must be missing something, could you please share where you found that setting PrivateNetwork sets PrivateMounts, or how to experimentally reproduce the difference? Thanks!

@name-snrl
Copy link
Copy Markdown
Contributor Author

where you found

https://www.freedesktop.org/software/systemd/man/latest/systemd.exec.html#PrivateNetwork=:

When this option is enabled, PrivateMounts= is implied unless it is explicitly disabled, and /sys will be remounted to associate it with the new network namespace

experimentally reproduce

systemd 254 (254.6) is all you need, I think

@max-baz
Copy link
Copy Markdown
Owner

max-baz commented Jan 26, 2024

Hmm interesting, my systemd is 254.8.. oh well, let's get this merged if it helps you, I don't see any downside 😁 Thanks!

@max-baz max-baz merged commit 94afd51 into max-baz:main Jan 26, 2024
@name-snrl
Copy link
Copy Markdown
Contributor Author

name-snrl commented Jan 26, 2024

finding any difference

The difference is that when only PrivateNetwork is set, wluma can't add any new learning entry. It creates .local/share/wluma/eDP-1.yaml from scratch, but no new entries are added there, so nothing worked for me then #92

@name-snrl name-snrl deleted the allow-wluma-update-state branch January 26, 2024 11:43
@max-baz
Copy link
Copy Markdown
Owner

max-baz commented Jan 26, 2024

Ahh okay thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants