Skip to content

Conversation

pavolloffay
Copy link

@pavolloffay pavolloffay commented Sep 15, 2023

Review this one after openshift#64716 is merged and the base branch of this PR is rebased.

Version(s):

Issue:

https://issues.redhat.com/browse/TRACING-3513

Link to docs preview:

openshift#64781 - https://64781--docspreview.netlify.app/

QE review:

  • QE has approved this change.

Additional information:

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay
Copy link
Author

@iblancasa could you please review?

@pavolloffay pavolloffay changed the title Document that OTEL operator can create service monitors TRACING-3513 | Document that OTEL operator can create service monitors Sep 20, 2023
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Copy link
Owner

@max-cx max-cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more suggestions to consider.

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@max-cx max-cx merged commit 8541093 into max-cx:distributed-tracing-3.0 Sep 20, 2023
max-cx pushed a commit that referenced this pull request Dec 23, 2024
TELCODOCS-1990: Docfooding feedback #2 applied

TELCODOCS-1990: Docfooding feedback #3 applied

TELCODOCS-1990: Docfooding feedback #4 applied

TELCODOCS-1990: Docfooding feedback #5 applied

TELCODOCS-1990: Docfooding feedback #6 applied

TELCODOCS-1990: Docfooding feedback #7 applied

TELCODOCS-1990: Docfooding feedback #8 applied

TELCODOCS-1990: Docfooding feedback #9 applied

TELCODOCS-1990: Docfooding feedback #10 applied

TELCODOCS-1990: Docfooding feedback #11 applied

TELCODOCS-1990: Peer review feedback applied

TELCODOCS-1990: Dev review feedback applied

TELCODOCS-1990: Dev/Peer review feedback applied

TELCODOCS-1990: Dev/Peer #2 review feedback applied

TELCODOCS-1990: Dev #2 review feedback applied

TELCODOCS-1990: Peer review squad feedback applied
max-cx pushed a commit that referenced this pull request Mar 13, 2025
TELCODOCS-1990: Docfooding feedback #2 applied

TELCODOCS-1990: Docfooding feedback #3 applied

TELCODOCS-1990: Docfooding feedback #4 applied

TELCODOCS-1990: Docfooding feedback #5 applied

TELCODOCS-1990: Docfooding feedback #6 applied

TELCODOCS-1990: Docfooding feedback #7 applied

TELCODOCS-1990: Docfooding feedback #8 applied

TELCODOCS-1990: Docfooding feedback #9 applied

TELCODOCS-1990: Docfooding feedback #10 applied

TELCODOCS-1990: Docfooding feedback #11 applied

TELCODOCS-1990: Peer review feedback applied

TELCODOCS-1990: Dev review feedback applied

TELCODOCS-1990: Dev/Peer review feedback applied

TELCODOCS-1990: Dev/Peer #2 review feedback applied

TELCODOCS-1990: Dev #2 review feedback applied

TELCODOCS-1990: Peer review squad feedback applied
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants