Skip to content

Improve support for large change sets #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
max-frank wants to merge 2 commits into from
Closed

Improve support for large change sets #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8a5395
Add tests with larger file contents
max-frank Mar 29, 2025
ae70e81
Pass file contents from file system
max-frank Mar 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
135 changes: 130 additions & 5 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,9 +213,20 @@ jobs:

git checkout -b $BRANCH_NAME
git push --set-upstream origin $BRANCH_NAME

echo $BRANCH_NAME > "test-file1.txt"
echo $BRANCH_NAME > "test-file2.txt"

file_content="$(mktemp temp-random-file-XXXXXX)"
# generate a file with 2.5MB of As
yes A | head -c 500000 > "$file_content"

for i in {1..10}
do
cp "$file_content" "test-file$i.txt"
echo "test-file$i.txt size: $(stat -c '%s' test-file$i.txt)"
done

# remove the temp file as we don't want to commit it
rm "$file_content"


git add .

Expand All @@ -240,12 +251,126 @@ jobs:
exit 1
fi

if [[ "$changedFilesIfAvailable" -ne 2 ]]; then
echo "Error: changedFilesIfAvailable is expected to be 2 but got $changedFilesIfAvailable."
if [[ "$changedFilesIfAvailable" -ne 10 ]]; then
echo "Error: changedFilesIfAvailable is expected to be 10 but got $changedFilesIfAvailable."
exit 1
fi

echo "Validation passed: changedFilesIfAvailable is $changedFilesIfAvailable."


test-very-large-file:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
ref: ${{ github.head_ref || github.ref }}
- name: Setup test branch
id: setup-test-branch
run: |
BRANCH_NAME="test_very_large_file-$(date +%s)"

git config --global user.name 'github-actions[bot]'
git config --global user.email 'github-actions[bot]@users.noreply.github.com'

git checkout -b $BRANCH_NAME
git push --set-upstream origin $BRANCH_NAME

# generate a file with 25MB of As
yes A | head -c 25000000 > test-file.txt
echo "test-file.txt size: $(stat -c '%s' test-file.txt)"

git add .

git status --porcelain=v2 --branch --untracked-files=no

echo "branch-name=$BRANCH_NAME" >> $GITHUB_OUTPUT
- uses: ./
id: test-action
with:
token: ${{ github.token }}
stage-all-files: false
commit-message: ${{ steps.setup-test-branch.outputs.branch-name }}
- name: Delete test branch
run: |
git push --force --delete origin ${{ steps.setup-test-branch.outputs.branch-name }}
- name: Check output
run: |
changedFilesIfAvailable=$(echo '${{ steps.test-action.outputs.commit-response }}' | jq -r '.data.createCommitOnBranch.commit.changedFilesIfAvailable')

if [[ -z "$changedFilesIfAvailable" || "$changedFilesIfAvailable" == "null" ]]; then
echo "Error: changedFilesIfAvailable is empty or null. Verify the output from test-action."
exit 1
fi

if [[ "$changedFilesIfAvailable" -ne 1 ]]; then
echo "Error: changedFilesIfAvailable is expected to be 1 but got $changedFilesIfAvailable."
exit 1
fi

echo "Validation passed: changedFilesIfAvailable is $changedFilesIfAvailable."


test-multiple-large-files:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
ref: ${{ github.head_ref || github.ref }}
- name: Setup test branch
id: setup-test-branch
run: |
BRANCH_NAME="test_multiple_large_files-$(date +%s)"

git config --global user.name 'github-actions[bot]'
git config --global user.email 'github-actions[bot]@users.noreply.github.com'

git checkout -b $BRANCH_NAME
git push --set-upstream origin $BRANCH_NAME

large_file="$(mktemp temp-random-file-XXXXXX)"
# generate a file with 2.5MB of As
yes A | head -c 2500000 > "$large_file"

for i in {1..10}
do
cp "$large_file" "test-file$i.txt"
echo "test-file$i.txt size: $(stat -c '%s' test-file$i.txt)"
done

# remove the temp file as we don't want to commit it
rm "$large_file"

git add .

git status --porcelain=v2 --branch --untracked-files=no

echo "branch-name=$BRANCH_NAME" >> $GITHUB_OUTPUT
- uses: ./
id: test-action
with:
token: ${{ github.token }}
stage-all-files: false
commit-message: ${{ steps.setup-test-branch.outputs.branch-name }}
- name: Delete test branch
run: |
git push --force --delete origin ${{ steps.setup-test-branch.outputs.branch-name }}
- name: Check output
run: |
changedFilesIfAvailable=$(echo '${{ steps.test-action.outputs.commit-response }}' | jq -r '.data.createCommitOnBranch.commit.changedFilesIfAvailable')

if [[ -z "$changedFilesIfAvailable" || "$changedFilesIfAvailable" == "null" ]]; then
echo "Error: changedFilesIfAvailable is empty or null. Verify the output from test-action."
exit 1
fi

if [[ "$changedFilesIfAvailable" -ne 10 ]]; then
echo "Error: changedFilesIfAvailable is expected to be 10 but got $changedFilesIfAvailable."
exit 1
fi

echo "Validation passed: changedFilesIfAvailable is $changedFilesIfAvailable."

test-file-rename: # make sure the action works on a clean machine without building
runs-on: ubuntu-latest
steps:
Expand Down
7 changes: 5 additions & 2 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,13 @@ runs:
done <<< "$status_output"
echo ""

contents_dir="$(mktemp -d)"
additions=""
for filepath in "${staged_additions[@]}"; do
file_content=$(cat "$filepath" | base64 | tr -d '\n') # Encode file content in Base64
additions+=" -F \"fileAdditions[][path]=$filepath\" -F \"fileAdditions[][contents]=$file_content\" "
contents_file="$(mktemp --tmpdir=$contents_dir temp-file-XXXXXX)"
cat "$filepath" | base64 | tr -d '\n' > "$contents_file" # Encode file content in Base64

additions+=" -F \"fileAdditions[][path]=$filepath\" -F \"fileAdditions[][contents]=@$contents_file\" "
done

deletions=""
Expand Down