You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Seems to do the thing. I still have a difference in behavior with my tests regarding empty tokens and empty delimiters primarily; for example, with the input "abcde" and a delimiter of "", I emit ["a", "b", "c", "d", "e"], while this package seems to emit "abcde". This could be seen as a behavioral choice and not a bug, but diverges from String.prototype.split. Equally, my code emits empty values in the case of an input such as "abba" with a delimiter of "b": ["a", "", "a"], while this code emits ["a", "a"]. Same thing. Neither really affects this PR, but they do block the PR I was originally preparing when filing #12 (which was to integrate my test suite into this package).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12 (better late than never!). Also has a nice side effect of ~8% performance improvement.
I assume this would warrant a major version bump just to be on the safe side?