Skip to content

Remove extension from savefig #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2025
Merged

Remove extension from savefig #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8b7f70
Removed extension argument
max-models Apr 12, 2025
252c1b0
Formatting
max-models Apr 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/maxplotlib/canvas/canvas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import os

import matplotlib.pyplot as plt
import plotly.graph_objects as go
from plotly.subplots import make_subplots
Expand Down Expand Up @@ -120,11 +122,12 @@ def add_subplot(self, **kwargs):
def savefig(
self,
filename,
extension="pdf",
backend="matplotlib",
layers=None,
layer_by_layer=False,
verbose=False,
):
filename_no_extension, extension = os.path.splitext(filename)
if backend == "matplotlib":
if layer_by_layer:
layers = []
Expand All @@ -133,17 +136,21 @@ def savefig(
fig, axs = self.plot(
show=False, backend="matplotlib", savefig=True, layers=layers
)
fig.savefig(f"{filename}_{layers}.{extension}")
_fn = f"{filename_no_extension}_{layers}.{extension}"
fig.savefig(_fn)
print(f"Saved {_fn}")
else:
if layers is None:
layers = self.layers
full_filepath = f"{filename}.{extension}"
full_filepath = filename
else:
full_filepath = f"{filename}_{layers}.{extension}"
full_filepath = f"{filename_no_extension}_{layers}.{extension}"
fig, axs = self.plot(
show=False, backend="matplotlib", savefig=True, layers=layers
)
fig.savefig(full_filepath)
if verbose:
print(f"Saved {full_filepath}")

def plot(self, backend="matplotlib", show=True, savefig=False, layers=None):
if backend == "matplotlib":
Expand Down