fix(skills): approve on trivial-change-skip when prior bot issues are resolved#145
Merged
fix(skills): approve on trivial-change-skip when prior bot issues are resolved#145
Conversation
… resolved The trivial-change-skip path in the review skill unconditionally skips approval, even when the "existing review" was a COMMENT flagging issues that the new trivial changes fix. This leaves PRs in limbo — reviewed but never approved despite all concerns being addressed. Add guidance to submit an APPROVE after thread resolution when the prior bot review was a COMMENT whose issues are now addressed. Evidence: max-sixty/worktrunk PR #1907, run 23976359110. Bot flagged a sync issue, pushed a fix commit, then the trivial-change-skip path exited without approving. Structural — the old instruction deterministically prevents approval regardless of prior review state. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
Run: 23976359110 (
tend-reviewondocs/cmux-integration, PR max-sixty/worktrunk#1907)The bot reviewed the PR and flagged a sync-test issue (COMMENTED review). It then pushed a fix commit itself. On the next run, the trivial-change-skip path fired correctly (only 4 lines changed in 1 file), but the instruction "do not submit a new approval — the existing review stands" meant the PR was left with zero approvals despite all concerns being addressed.
Classification: Structural — the old instruction deterministically prevents approval on the trivial-change-skip path regardless of the prior review's state. Replaying this scenario would always produce the same result.
Root cause: The trivial-change-skip instruction treated all prior reviews as equivalent. A prior APPROVE review doesn't need refreshing, but a prior COMMENT review that flagged issues does need an APPROVE once those issues are fixed.
Gate assessment
Change
Rewrote the trivial-change-skip paragraph to: resolve threads first (step 7), then check whether the prior bot review was a COMMENT with now-addressed issues → approve. Otherwise, keep the existing "do not submit a new review" behavior.
🤖 Generated with Claude Code