Skip to content

refactor(mention): move behavioral instructions from prompt to skill#235

Merged
max-sixty merged 1 commit into
mainfrom
mention-review-inline-reply-prompt
Apr 10, 2026
Merged

refactor(mention): move behavioral instructions from prompt to skill#235
max-sixty merged 1 commit into
mainfrom
mention-review-inline-reply-prompt

Conversation

@max-sixty
Copy link
Copy Markdown
Owner

The mention prompt duplicated guidance already in the running-in-ci skill (reply mechanics, multi-way conversation rules, context reading instructions). This moves general behavioral instructions into the shared skill and slims each prompt branch to event-specific context only.

Skill additions (running-in-ci/SKILL.md): review inline comment fetching by review ID, review concerns acknowledgment, self-conversation guard, triage skill loading gate.

Prompt removals (workflows.py): exact gh api reply commands, detailed context-reading lists (description, diff, recent comments, CI status), multi-way conversation rules, self-conversation guard, triage loading instruction. Drops github.repository format arg from pull_request_review_comment branches (4→3 args).

Each prompt branch now follows a consistent pattern: identify event → pass dynamic values (URLs, IDs) → state core action. Everything about how to carry out the action (reply mechanics, when to respond, how to read context) lives in the skill.

This was written by Claude Code on behalf of @max-sixty

…g-in-ci skill

The mention prompt duplicated guidance already present in the running-in-ci skill (reply mechanics, multi-way conversation rules, context reading). Move general behavioral instructions to the shared skill where all CI runs benefit, and slim each prompt branch to contain only event-specific context.

Skill additions: review inline comment fetching by review ID, review concerns acknowledgment, self-conversation guard, triage skill loading gate.

Prompt removals: exact gh api reply commands, detailed context-reading lists, multi-way conversation rules, self-conversation guard, triage loading — all now in the skill. Drops github.repository format arg from pull_request_review_comment branches (4→3 args).

Co-Authored-By: Claude <noreply@anthropic.com>
@max-sixty max-sixty merged commit f7fda2a into main Apr 10, 2026
3 checks passed
@max-sixty max-sixty deleted the mention-review-inline-reply-prompt branch April 10, 2026 21:22
tend-agent added a commit that referenced this pull request Apr 11, 2026
Syncs the checked-in workflow file with the in-repo generator. Pulls in
changes from #225 (pull_request_review_comment dedup), #233 (drop
bot-author filter), #228 (--paginate on gh api), and #235 (move
behavioral instructions from prompt to skill).

Generated with the local `generator/` source tree rather than
`uvx tend@latest init`, because PyPI 0.0.11 lags behind main for these
changes — running `uvx tend@latest init` against the current tree would
*add* `timeout-minutes: 60` back and drop the mention generator updates.
tend-agent pushed a commit that referenced this pull request Apr 13, 2026
When `generator/pyproject.toml` exists (i.e. on the tend repo itself),
Step 5 of the nightly skill now regenerates workflows via the in-tree
generator instead of `uvx tend@latest`. Adopter repos without `generator/`
fall through to the existing `uvx tend@latest` path unchanged.

Motivation: PR #264 (from run 24330194038) ran `uvx tend@latest init` with
PyPI's `tend` at 0.0.11 (released 2026-04-10). `main` has 10 generator
commits landed since — #223 (drop hardcoded job timeouts), #225 (dedup
review events), #227 (workflow_extra), #228 (paginate), #231 (inline-reply
guidance), #233 (drop bot-author filter on issue_comment), #235 (prompt →
skill), #254 (notifications freshness gate + bot-closed-PR drop), etc.
Regenerating against the stale wheel reverted each of these. Maintainer
flagged the PR as regressions; diagnosis confirmed the PyPI lag.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants