Conversation
CommandEnv used .path() (which returns "." or whatever base_path was set
to) instead of .root() (which runs `git rev-parse --show-toplevel`). When
running from a subdirectory, hooks got the wrong CWD and template
variables like {{ worktree_path }} resolved to "." instead of the
absolute worktree root.
Co-Authored-By: Claude <noreply@anthropic.com>
worktrunk-bot
approved these changes
Feb 18, 2026
On Windows, to_posix_path() converts C:\... to /c/... for Git Bash
compatibility. Path::is_absolute() rejects this POSIX-style path on
Windows. Use assert_ne!(".", ...) instead — what matters is that the
path is not relative.
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CommandEnvused.path()(returns"."by default) instead of.root()(git rev-parse --show-toplevel) forworktree_path{{ worktree_path }}resolved to".", and{{ worktree_name }}resolved to"unknown".root()for this —CommandEnvwas the outlierTest plan
test_hook_template_variables_from_subdirectory— runswt hook pre-mergefromsrc/components/subdirectory, verifies{{ worktree_path }}is absolute,{{ worktree_name }}is correct, and hook CWD is the worktree root.path()code (hook writes files to subdirectory, not worktree root)