Increase stdin timeout for Windows compatibility#174
Merged
Conversation
Two switch tests have fundamental platform differences: - test_switch_execute_failure: On Unix, --execute uses exec() which replaces the process, so no error message is shown. On Windows, spawn-and-wait reports the exit status. - test_switch_missing_argument_shows_hints: Hints display differently. The directives test (test_remove_internal_powershell_directive) passes on all platforms and remains enabled. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Two fixes to align cross-platform behavior: 1. Fix hints display on Windows: The check for "wt switch" in error messages now also checks for "wt.exe switch" (Windows executable). 2. Fix --execute error handling on Windows: When --execute command fails, Windows now exits with the command's exit code without showing an error message, matching Unix behavior where exec() replaces the process. Enables two previously Windows-skipped tests: - test_switch_execute_failure - test_switch_missing_argument_shows_hints 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Increased the stdin read timeout from 10ms to 50ms in statusline command. Windows process spawning is slower, causing a race condition where stdin data wouldn't arrive in time. 50ms is still imperceptible to users but gives Windows enough headroom. Enables 2 additional Windows tests: - test_statusline_claude_code_full_context - test_statusline_claude_code_with_model 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code