fix(config show): don't show false 'Not configured' when shell integration is active#2066
Merged
fix(config show): don't show false 'Not configured' when shell integration is active#2066
Conversation
…ation is active When the init line lives in a sourced file (common with dotfile managers like stow/chezmoi), config show couldn't find it and reported "Not configured" despite integration working. Now checks runtime state for the current shell and shows "Configured (not found in ~/.zshrc)" instead. Closes #1306 Co-Authored-By: Claude <noreply@anthropic.com>
Tests the #1306 scenario: shell integration is active at runtime (directive file set) but the init line isn't in ~/.zshrc (sourced from another file). Verifies the output shows "Configured ... (not found in ~/.zshrc)" instead of the false "Not configured" warning. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the init line lives in a sourced file (common with dotfile managers like stow/chezmoi),
wt config showcouldn't find it in the scanned config files and reported "Not configured" despite integration working fine at runtime.Now checks
is_shell_integration_active()for the current shell before showing "Not configured" — if integration is provably active, shows "Configured (not found in ~/.zshrc)" instead.Thanks to @wouter-intveld for reporting in #1306
Closes #1306