fix: documentation incorrectly shows ~ concatenation with | filter without parentheses #373
+23
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thout parentheses
Co-Authored-By: Claude <noreply@anthropic.com>
Owner
|
thanks a lot @coriocactus ! |
max-sixty
added a commit
that referenced
this pull request
Jan 2, 2026
Ensures template examples in docs work as described. Tests cover basic variables, filters (sanitize, hash_port), operator precedence with concatenation, and full command examples from docs. Catches issues like PR #373 where operator precedence was documented incorrectly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
2 tasks
max-sixty
added a commit
that referenced
this pull request
Jan 2, 2026
Ensures template examples in docs work as described. Tests cover basic variables, filters (sanitize, hash_port), operator precedence with concatenation, and full command examples from docs. Catches issues like PR #373 where operator precedence was documented incorrectly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue (#372)
Jinja2's operator precedence has pipe
|with higher precedence than concatenation~, meaning expressions need parentheses to filter concatenated values:'db-' ~ branch | hash_portparses as'db-' ~ (branch | hash_port)therefore should be written as('db-' ~ branch) | hash_port. Similarlyrepo ~ '-' ~ branch | hash_portshould be written as(repo ~ '-' ~ branch) | hash_port.(FYI I'm a rust n00b. In addition to documentation changes, I've made code changes in
src/config/expansion.rs.)