fix: correctly use the default value of CellStateStyle.editable
#570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Graph.isCellEditable` considered that the default value was `false`. The code hadn't been correctly migrated from mxGraph, see https://github.com/jgraph/mxgraph/blob/v4.2.2/javascript/src/js/view/mxGraph.js#L10542-L10557 So, to configure a Cell as "editable", the style of Cell had to be explicitly configured the editable property to `true`.
9 tasks
tbouffard
changed the title
CellStateStyle.editableCellStateStyle.editable
7 tasks
tbouffard
deleted the
fix/use_right_default_value_CellStateStyle.editable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graph.isCellEditableconsidered that the default value wasfalse.The code hadn't been correctly migrated from mxGraph, see https://github.com/jgraph/mxgraph/blob/v4.2.2/javascript/src/js/view/mxGraph.js#L10542-L10557
So, to configure a Cell as "editable", the style of Cell had to be explicitly configured the editable
property to
true.Notes
Covers #544
First detected in #532