feat: let configure the defaults value of the shadow styles #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `mxGraph`, such configuration was possible by updating certain `mxConstants` values, but in `maxGraph`, constants are immutable. It is now possible to use `StyleDefaultsConfig` to globally configure various shadow style parameters. Previously, setting such parameters was a real pain. Certain methods had to be reimplemented in Canvas2D classes. Finally, it is now possible to reset `StyleDefaultsConfig` properties to their default values using a dedicated reset function. A new story has been added to demonstrate the effects of customizing style defaults and compare them with the original defaults. Some existing stories have also been modified to change the default shadow settings to better match the related mxGraph examples from which they were taken.
tbouffard
commented
Nov 18, 2024
tbouffard
deleted the
feat/allow_configure_global_style_defaults_shadow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
mxGraph, such configuration was possible by updating certainmxConstantsvalues, but inmaxGraph, constants are immutable.It is now possible to use
StyleDefaultsConfigto globally configure various shadow style parameters.Previously, setting such parameters was a real pain. Certain methods had to be reimplemented in Canvas2D classes.
Finally, it is now possible to reset
StyleDefaultsConfigproperties to their default values using a dedicated reset function.A new story has been added to demonstrate the effects of customizing style defaults and compare them with the original defaults.
Some existing stories have also been modified to change the default shadow settings to better match the related mxGraph examples from which they were taken.
Screenshots
A new story demonstrates how it is possible to changes the default shadow style values 👇🏿
PR_577_custom_default_shadow_styles.webm
Notes
Covers #192