refactor!: remove unused domUtils.importNodeImplementation #648
Conversation
In mxGraph, it was only used at a single place to "support older versions of IE". https://github.com/jgraph/mxgraph/blob/ff141aab158417bd866e2dfebd06c61d40773cd2/javascript/src/js/util/mxSvgCanvas2D.js#L1270 BREAKING CHANGES: this function has been removed because it was unused. It was only used internally in `mxGraph` and should not have been exposed.
WalkthroughThe pull request focuses on cleaning up and simplifying the codebase by removing unused or problematic functions and properties. Specifically, the changes involve removing the Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
19-19: Enhance the changelog entry with more details.The breaking change entry should follow the same format as other entries and provide more context for users. Consider the following improvements:
-- `domUtils.importNodeImplementation` has been removed because it was unused. It was only used internally in `mxGraph` and should not have been exposed. +- `domUtils.importNodeImplementation` has been removed: + - This function was only used internally in `mxGraph` to support older versions of IE + - It was not intended to be part of the public API + - No migration steps are needed as the function was unused
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)packages/core/src/util/domUtils.ts(0 hunks)
💤 Files with no reviewable changes (1)
- packages/core/src/util/domUtils.ts
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build (windows-2022)
|
tbouffard
deleted the
refactor/remove_unused_domUtils_importNodeImplementation
branch
1 participant
In mxGraph, it was only used at a single place to "support older versions of IE".
https://github.com/jgraph/mxgraph/blob/ff141aab158417bd866e2dfebd06c61d40773cd2/javascript/src/js/util/mxSvgCanvas2D.js#L1270
BREAKING CHANGES: this function has been removed because it was unused.
It was only used internally in
mxGraphand should not have been exposed.Summary by CodeRabbit
importNodeImplementationfunction for clarity.EdgeHandlerproperties with more descriptive global configurations.importNodemethod.