-
Notifications
You must be signed in to change notification settings - Fork 194
docs: apply improvements to the navbar #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use the GitHub logo instead of a label for the link to the GitHub repository to make the right-hand side more attractive (logos only). Hide the navigation bar when scrolling to free up screen space for reading. Also improved the footer: “Built with Docusaurus” is now a link to the docusaurus website, to advertise this tool.
WalkthroughThis pull request modifies the website's configuration and styles. In the Docusaurus configuration file, a new Changes
Possibly related PRs
Suggested labels
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/website/src/css/custom.css (1)
32-45
: LGTM! Consider extracting SVG data URLs.The implementation is well-structured with proper dark mode support. However, the SVG data URLs make the CSS less maintainable.
Consider extracting the SVG data URLs to separate files:
-.header-github-link:before { +.header-github-link:before { content: ''; width: 24px; height: 24px; display: flex; - background: url("data:image/svg+xml,%3Csvg viewBox='0 0 24 24' xmlns='http://www.w3.org/2000/svg'%3E%3Cpath d='M12 .297c-6.63 0-12 5.373-12 12 0 5.303 3.438 9.8 8.205 11.385.6.113.82-.258.82-.577 0-.285-.01-1.04-.015-2.04-3.338.724-4.042-1.61-4.042-1.61C4.422 18.07 3.633 17.7 3.633 17.7c-1.087-.744.084-.729.084-.729 1.205.084 1.838 1.236 1.838 1.236 1.07 1.835 2.809 1.305 3.495.998.108-.776.417-1.305.76-1.605-2.665-.3-5.466-1.332-5.466-5.93 0-1.31.465-2.38 1.235-3.22-.135-.303-.54-1.523.105-3.176 0 0 1.005-.322 3.3 1.23.96-.267 1.98-.399 3-.405 1.02.006 2.04.138 3 .405 2.28-1.552 3.285-1.23 3.285-1.23.645 1.653.24 2.873.12 3.176.765.84 1.23 1.91 1.23 3.22 0 4.61-2.805 5.625-5.475 5.92.42.36.81 1.096.81 2.22 0 1.606-.015 2.896-.015 3.286 0 .315.21.69.825.57C20.565 22.092 24 17.592 24 12.297c0-6.627-5.373-12-12-12'/%3E%3C/svg%3E") + background: url('/img/github.svg') no-repeat; } -html[data-theme='dark'] .header-github-link:before { - background: url("data:image/svg+xml,%3Csvg viewBox='0 0 24 24' xmlns='http://www.w3.org/2000/svg'%3E%3Cpath fill='white' d='M12 .297c-6.63 0-12 5.373-12 12 0 5.303 3.438 9.8 8.205 11.385.6.113.82-.258.82-.577 0-.285-.01-1.04-.015-2.04-3.338.724-4.042-1.61-4.042-1.61C4.422 18.07 3.633 17.7 3.633 17.7c-1.087-.744.084-.729.084-.729 1.205.084 1.838 1.236 1.838 1.236 1.07 1.835 2.809 1.305 3.495.998.108-.776.417-1.305.76-1.605-2.665-.3-5.466-1.332-5.466-5.93 0-1.31.465-2.38 1.235-3.22-.135-.303-.54-1.523.105-3.176 0 0 1.005-.322 3.3 1.23.96-.267 1.98-.399 3-.405 1.02.006 2.04.138 3 .405 2.28-1.552 3.285-1.23 3.285-1.23.645 1.653.24 2.873.12 3.176.765.84 1.23 1.91 1.23 3.22 0 4.61-2.805 5.625-5.475 5.92.42.36.81 1.096.81 2.22 0 1.606-.015 2.896-.015 3.286 0 .315.21.69.825.57C20.565 22.092 24 17.592 24 12.297c0-6.627-5.373-12-12-12'/%3E%3C/svg%3E") +html[data-theme='dark'] .header-github-link:before { + background: url('/img/github-dark.svg') no-repeat; }This would improve maintainability and reduce the CSS file size. The SVGs can be optimized using tools like SVGO.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/website/docusaurus.config.ts
(3 hunks)packages/website/src/css/custom.css
(1 hunks)
🔇 Additional comments (3)
packages/website/docusaurus.config.ts (3)
84-84
: LGTM! Good UX improvement.The
hideOnScroll
feature will help maximize screen space for content reading, improving the overall user experience.
111-116
: LGTM! Good accessibility practice.The changes maintain accessibility while improving visual appeal:
- Using
aria-label
ensures screen readers can still identify the GitHub link- The
header-github-link
class will be used to style the GitHub icon
168-168
: LGTM! Good security practice.The Docusaurus link implementation includes proper security attributes:
target="_blank"
for opening in new tabrel="noopener noreferrer"
to prevent security vulnerabilities
Use the GitHub logo instead of a label for the link to the GitHub repository to make the right-hand side more attractive (logos only).
Hide the navigation bar when scrolling to free up screen space for reading.
Also improved the footer: “Built with Docusaurus” is now a link to the docusaurus website, to advertise this tool.
Notes
Former display
maxgraph_website_0.15.1.webm
New display
maxgraph_website_PR_675.webm
Summary by CodeRabbit
New Features
Style