refactor: use external CSS file MenuStyle and ShowRegion stories #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the CSS was included programmatically in the document, which is not the best way to add CSS in the storybook context. In this case, the CSS was added each time the story was rendered, so the CSS definition was added multiple times The stories now use external CSS and use imports to include them. This removes the duplicated includes in the DOM and makes the thing easier to understand by using standard practices. Notice that the Scrollbars story is still using the former way of including custom CSS. It is not functional and requires additional work. So, it will be updated later.
WalkthroughThe changes remove inline CSS definitions and the dynamic creation of a Changes
Sequence Diagram(s)sequenceDiagram
participant Story as Story File
participant Browser as Browser
participant CSS as External CSS File
Story->>Browser: Load component with style imports
Browser->>CSS: Request and fetch external stylesheet(s)
CSS-->>Browser: Return styling rules
Browser-->>Story: Render component with applied styles
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (3)
🔇 Additional comments (1)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the CSS was included programmatically in the document, which is not the best way to add CSS in the storybook
context. In this case, the CSS was added each time the story was rendered, so the CSS definition was added multiple
times
The stories now use external CSS and use imports to include them. This removes the duplicated includes in the DOM and
makes the thing easier to understand by using standard practices.
Notice that the Scrollbars story is still using the former way of including custom CSS.
It is not functional and requires additional work. So, it will be updated later.
Summary by CodeRabbit