fix: correctly set italic in styleUtils.getSizeForString

[tbouffard]

The problem was introduced in 6fc05a3, probably by a wrong copy/paste of the previous line of code.
When the text was in italic, the style attribute 'fontWeight' was incorrectly set instead of the 'fontStyle' attribute.
The returned size was then incorrect.

Notes

Discovered in #804 (review)

Summary by CodeRabbit

• Bug Fixes

  • Corrected the application of italic font style so that text now properly appears italicized when expected.

• Documentation

  • Clarified the description of the font style parameter in documentation.

[coderabbitai]

Walkthrough

The update modifies the getSizeForString function in the style utilities module. It corrects how the function applies the italic font style to a temporary DOM element by setting the fontStyle property instead of fontWeight when the FONT.ITALIC bitmask is present. Additionally, the JSDoc comment for the fontStyle parameter is clarified to indicate its typical source. No changes were made to the function's signature or other exported entities.

Changes

File	Change Summary
packages/core/src/util/styleUtils.ts	Corrected logic for applying italic font style in getSizeForString and clarified JSDoc comment.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6d99b3a and a644212.

📒 Files selected for processing (1)

• packages/core/src/util/styleUtils.ts (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

packages/core/src/util/styleUtils.ts (1)

packages/core/src/internal/utils.ts (1)

• matchBinaryMask (68-70)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: build
• GitHub Check: build (windows-2022)
• GitHub Check: build (macos-14)
• GitHub Check: build (ubuntu-22.04)

🔇 Additional comments (2)

packages/core/src/util/styleUtils.ts (2)

436-436: Improve JSDoc description for fontStyle parameter

The updated JSDoc clearly indicates that fontStyle is generally taken from CellStateStyle.fontStyle, improving clarity and guiding users on its origin.

---

454-456: Correct italic style assignment

This change fixes the copy/paste error by setting div.style.fontStyle = 'italic' when the FONT.ITALIC bitmask is present, ensuring accurate size calculations for italic text.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud