feat: ease webpack configuration and add support Node ESM #867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, maxGraph integration in a webpack build required the addition of a specific configuration. Imports into maxGraph code did not include the “js” extension required by webpack for import resolution. A workaround was needed in the configuration, otherwise an error would occur. For the same reason, Node.js emitted an error when importing maxGraph into ESM scripts or applications. No workaround was available. All imports into maxGraph ESM code provided in the npm package now include the “js” extension, which corrects both past problems. A new eslint plugin has been added to reinforce the “js” extension. It provides an automatic correction for the corresponding rule. The webpack and Node ESM examples in this repository have been updated to demonstrate the new behavior.
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 161 files out of 268 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, maxGraph integration in a webpack build required the addition of a specific configuration.
Imports into maxGraph code did not include the “js” extension required by webpack for import resolution. A workaround was needed in the configuration, otherwise an error would occur.
For the same reason, Node.js emitted an error when importing maxGraph into ESM scripts or applications. No workaround was available.
All imports into maxGraph ESM code provided in the npm package now include the “js” extension, which corrects both past problems.
A new eslint plugin has been added to reinforce the “js” extension. It provides an automatic correction for the corresponding rule.
The webpack and Node ESM examples in this repository have been updated to demonstrate the new behavior.
Notes
Closes #827