Skip to content

Conversation

@maxbarsukov
Copy link
Owner

  • Add servers section;
  • Fix some OAS3 validated errors;
  • Improve swagger docs paths (remove /api/v1);
  • Fix rswag base url with before/after hooks in swagger_test shared context;

@codecov
Copy link

codecov bot commented Apr 17, 2022

Codecov Report

Merging #97 (ca423d0) into master (3a390a6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #97   +/-   ##
=========================================
  Coverage   93.890%   93.890%           
=========================================
  Files          107       107           
  Lines         1113      1113           
=========================================
  Hits          1045      1045           
  Misses          68        68           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a390a6...ca423d0. Read the comment docs.

@gitguardian
Copy link

gitguardian bot commented Apr 17, 2022

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
3188619 Generic High Entropy Secret a402a9e docs/swagger/v1/swagger.json View secret
3188620 Generic High Entropy Secret a402a9e docs/swagger/v1/swagger.json View secret
3190286 Generic High Entropy Secret a402a9e docs/swagger/v1/swagger.json View secret
3190287 Generic High Entropy Secret a402a9e docs/swagger/v1/swagger.json View secret
3188621 Generic High Entropy Secret a402a9e docs/swagger/v1/swagger.json View secret
3188622 Generic High Entropy Secret a402a9e docs/swagger/v1/swagger.json View secret
3190288 Generic High Entropy Secret a402a9e docs/swagger/v1/swagger.json View secret
3190289 Generic High Entropy Secret a402a9e docs/swagger/v1/swagger.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@maxbarsukov maxbarsukov merged commit 768ff0f into master Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants