Skip to content

Conversation

@chrisminett
Copy link
Member

@chrisminett chrisminett commented Jul 20, 2025

Revert the token authentication changes added in #18 , keeping the deprecation for getConfig().

Although this is essentially a BC break as it removes code, no implementation can have used token auth as it is not live in the Maxemail app.

@chrisminett chrisminett self-assigned this Jul 20, 2025
@chrisminett chrisminett added the patch-version Release CAN be patch version increment label Jul 20, 2025
@codecov
Copy link

codecov bot commented Jul 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.86%. Comparing base (f105360) to head (042ecb7).
Report is 3 commits behind head on 5.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                5.x      #20      +/-   ##
============================================
- Coverage     86.07%   85.86%   -0.21%     
+ Complexity       77       75       -2     
============================================
  Files             5        5              
  Lines           280      276       -4     
============================================
- Hits            241      237       -4     
  Misses           39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chrisminett chrisminett force-pushed the revert-token-auth-5 branch from 26f0803 to 042ecb7 Compare July 20, 2025 07:23
@chrisminett
Copy link
Member Author

Checking that the token auth code has been correctly reverted:

@chrisminett chrisminett merged commit 44c9ca8 into 5.x Jul 20, 2025
20 checks passed
@chrisminett chrisminett deleted the revert-token-auth-5 branch July 20, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch-version Release CAN be patch version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants