Add support for the is_residential_proxy output #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't have it. This needed to change because of the update to the maxmind-db submodule (where it was fixed/removed).
oschwald
requested changes
Sep 24, 2020
| } | ||
|
|
||
| /** | ||
| * @return This is true if the IP address is on a suspected anonymizing |
Member
There was a problem hiding this comment.
It looks like all of the other boolean docs are of the form @return whether .... Perhaps we should update this to be similar here and in the Traits class.
Contributor
Author
There was a problem hiding this comment.
I updated it here. For the Traits class, most of them were in this form. I updated one that wasn't. I can make the Traits class use the whether form if you think it's best too though.
Member
There was a problem hiding this comment.
Weird. I don't think it matters too much. Ideally we would be consistent everywhere, but this seems good enough given the current state of things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.