Release 5.1.0#699
Conversation
oschwald
commented
May 12, 2026
oschwald
commented
- Update maxmind-db to 4.1.0
- Update lock file
- Set release date
- Preparing for 5.1.0
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project version to 5.1.0 and bumps the maxmind-db dependency to 4.1.0 to address memory growth and short-read issues. It also includes updates to the changelog, documentation, and lock files. A review comment correctly identifies that updating the japicmp.baselineVersion to 5.1.0 is premature and will cause build failures during API compatibility checks, as this version is not yet available on Maven Central.
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <!-- Baseline version for API compatibility checking. Update after each release. --> | ||
| <japicmp.baselineVersion>5.0.2</japicmp.baselineVersion> | ||
| <japicmp.baselineVersion>5.1.0</japicmp.baselineVersion> |
There was a problem hiding this comment.
Updating japicmp.baselineVersion to 5.1.0 is premature. This property is used by the maven-antrun-plugin (line 320) to download the baseline JAR from Maven Central for API compatibility checks. Since version 5.1.0 is the version currently being released and is not yet available in Maven Central, the build will fail with a 404 error when the api-compat profile is active. As noted in the comment on line 105, this should be updated after the release is published. For now, it should continue to point to the previous release (5.0.2).
| <japicmp.baselineVersion>5.1.0</japicmp.baselineVersion> | |
| <japicmp.baselineVersion>5.0.2</japicmp.baselineVersion> |
2 participants
