Drop Python 2 support #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oschwald
force-pushed
the
greg/py3
branch
2 times, most recently
from
77e78dd to
ad604e4
Compare
oschwald
force-pushed
the
greg/py3
branch
2 times, most recently
from
9961b96 to
e40e6fa
Compare
horgh
requested changes
Jul 13, 2020
| self.close() | ||
|
|
||
| def country(self, ip_address): | ||
| def country(self, ip_address: IPAddress) -> Country: |
Contributor
There was a problem hiding this comment.
Do we need to cast() the model_for call here?
Member
Author
There was a problem hiding this comment.
Good catch. mypy doesn't catch that one for some reason. These aren't actual runtime check so if they are wrong, it will just result in linting errors.
geoip2/records.py
Outdated
| iso_code=None, | ||
| names=None, | ||
| locales: Optional[List[str]] = None, | ||
| confidence: None = None, |
Contributor
There was a problem hiding this comment.
Is this correct? As in, could it be an optional int?
geoip2/webservice.py
Outdated
| license_key: str, | ||
| host: str = "geoip.maxmind.com", | ||
| locales: Optional[List[str]] = None, | ||
| timeout: None = None, |
HISTORY.rst
Outdated
| 4.0.0 | ||
| ++++++++++++++++++ | ||
|
|
||
| * IMPORTANT: Python 2.7 and 3.5 support have been drop. Python 3.6 or greater |
horgh
requested changes
Jul 13, 2020
HISTORY.rst
Outdated
| 4.0.0 | ||
| ++++++++++++++++++ | ||
|
|
||
| * IMPORTANT: Python 2.7 and 3.5 support has been drop. Python 3.6 or greater |
Member
Author
There was a problem hiding this comment.
Doh, I was so focused on whether the plural or singular was actually right that I totally missed that.
Member
Author
There was a problem hiding this comment.
I cleaned up the history a bit and applied the changes to the original commit that added the line.
Although we don't currently use flake8 in CI, this is nice for anyone who has it enabled in their editor.
Not sure why these are there. I think an early prototype of GeoIP2 City has the postal values in location. Perhaps they are from that.
And switch a complicated yet mislead type signature to Any.
This is mostly so I can install from Git for minfraud and get 4.0.0.
horgh
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.