Add async web request support. Closes #56 #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to share between Client and AsyncClient. Also, don't compute user_agent on every request.
This basically reverts #24. httpretty seems well maintained these days and it makes it easy to switch out the HTTP client libraries without changing the tests.
oschwald
force-pushed
the
greg/async-http
branch
from
22b033e to
c02398f
Compare
oschwald
force-pushed
the
greg/async-http
branch
from
c02398f to
5346e3c
Compare
oschwald
force-pushed
the
greg/async-http
branch
from
9f9fe63 to
8f6785b
Compare
horgh
approved these changes
Jul 17, 2020
Contributor
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56.