Require Java 17+ #285
Merged
Require Java 17+ #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oschwald
commented
Aug 26, 2025
oschwald
commented
- Drop Java 11 support, require Java 17
- Convert CtrlData to record
- Convert CacheKey to record
- Convert CachedConstructor to record
- Use pattern matching for instanceof
- Convert switch statements to expressions
- Update collections to use modern factory methods
- Remove whitespace at line ends
- Update Maven compiler plugin to use Java 17 - Update GitHub Actions CI to test Java 17, 21, and 24 - Update README requirements - Update CHANGELOG for version 4.0.0 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
oschwald
force-pushed
the
greg/eng-2665
branch
from
562b6f4 to
9e92d46
Compare
Converts the CtrlData class to use Java 17 records, reducing boilerplate and improving memory layout. Updates all getter method calls to use record accessors. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Converts the CacheKey class to use Java 17 records, reducing boilerplate and improving memory layout. Updates all getter method calls to use record accessors and adds proper Javadoc for record parameters. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Converts the internal CachedConstructor class to use Java 17 records, reducing boilerplate and improving memory layout. Updates all getter method calls to use record accessors. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Converts instanceof checks to use Java 17 pattern matching where applicable, eliminating explicit casting and reducing boilerplate. This makes the code more concise and type-safe. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
oschwald
force-pushed
the
greg/eng-2665
branch
from
9e92d46 to
c56bbfa
Compare
Converts the decodeBoolean method switch statement to use Java 17 switch expressions, making the code more concise and eliminating the need for break statements. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Replaces Arrays.asList() with List.of() for creating immutable lists and updates empty array initialization to use modern syntax. This improves performance and readability. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
oschwald
force-pushed
the
greg/eng-2665
branch
from
6177a41 to
da38d74
Compare
Replace raw types with properly parameterized generics: - ConcurrentHashMap<Class, CachedConstructor> → ConcurrentHashMap<Class<?>, CachedConstructor<?>> - CacheKey → CacheKey<?> - Map t → Map<String, Object> t Add type-safe helper method getCachedConstructor() to encapsulate necessary unchecked cast with clear documentation of safety invariant. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
oschwald
force-pushed
the
greg/eng-2665
branch
from
da38d74 to
bd42688
Compare
horgh
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.