Turn new exceptions into unchecked runtime exceptions #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horgh
force-pushed
the
horgh/exceptions
branch
2 times, most recently
from
800a6bc to
0c518d9
Compare
These should not happen, so do not include them in the API.
horgh
force-pushed
the
horgh/exceptions
branch
from
0c518d9 to
6620038
Compare
oschwald
requested changes
Aug 24, 2020
Member
oschwald
left a comment
oschwald
left a comment
There was a problem hiding this comment.
Nice cleanup! Could you add something to the changelog about Record => DatabaseRecord?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.