Skip to content

Add cache value class #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
horgh merged 7 commits into from
Aug 27, 2020
Merged

Add cache value class #80

horgh merged 7 commits into from
Aug 27, 2020

Conversation

@oschwald
Copy link
Member

@oschwald oschwald commented Aug 27, 2020

This provides us with more flexibility to change what is cached.

@oschwald
Improve exception message
389e2cf
@oschwald
Use cache again
6872cc7
@oschwald
Use new class for cache
8cd4f8f 
This gives us more flexibility to change the contents of the cache
without a breaking change (and avoiding a cast). In particular, we may
need to store the final offset as we extend the cache.
@oschwald
Update class name in docs
910a4b3
@oschwald
Simplify equals code slightly
56cad6f
@oschwald
Remove unused import
33eda76
@oschwald
Use JUnit comparison methods
09c13ca
@coveralls
Copy link

coveralls commented Aug 27, 2020

Coverage Status

Coverage increased (+2.9%) to 90.0% when pulling 09c13ca on greg/cache-value-class into 3431dac on development.

@horgh horgh merged commit e0a7dc3 into development Aug 27, 2020
@horgh horgh deleted the greg/cache-value-class branch August 27, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@horgh horgh horgh approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oschwald @coveralls @horgh