Add GeoIP-Residential-Proxy test fixture#239
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for the 'GeoIP-Residential-Proxy' database by updating the database type mapping in 'pkg/writer/geoip2.go' and introducing a new test data file 'source-data/GeoIP-Residential-Proxy-Test.json'. A review comment suggests reordering the new map entry to maintain the alphabetical consistency of the 'dbTypes' map.
| "GeoIP2-ISP": "GeoIP2-ISP-Test.json", | ||
| "GeoIP2-Precision-Enterprise": "GeoIP2-Precision-Enterprise-Test.json", | ||
| "GeoIP2-Precision-Enterprise-Shield": "GeoIP2-Precision-Enterprise-Test.json", | ||
| "GeoIP-Residential-Proxy": "GeoIP-Residential-Proxy-Test.json", |
There was a problem hiding this comment.
The dbTypes map is currently maintained in alphabetical order. GeoIP-Residential-Proxy should be moved up to follow GeoIP-Anonymous-Plus (line 20) and precede GeoIP2-Anonymous-IP (line 21) to maintain this consistency.
Adds a 27-record test MMDB for the GeoIP-Residential-Proxy database type, matching the schema produced by mm_website's build-residential-proxy-mmdb (provider_name, anonymizer_confidence, network_last_seen). One IPv6 record intentionally omits anonymizer_confidence so downstream consumers can verify they handle the absent-field case. Part of STF-445. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
klp2
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a 27-record test MMDB for the
GeoIP-Residential-Proxydatabase type so downstream consumers (libmaxminddb, maxminddb-golang, etc.) have a fixture to test reader support against.The record schema matches what mm_website's
build-residential-proxy-mmdbproduces in production:provider_name(string),anonymizer_confidence(uint16),network_last_seen(stringYYYY-MM-DD)./32records spanning user-chosen reserved/8ranges (6.0.0.0/8,7.0.0.0/8, ...,215.0.0.0/8)/64records under2001:480::/322001:480:725b:17e::/64) intentionally omitsanonymizer_confidenceso consumers can verify the absent-field pathPart of STF-445.
Test plan
go run ./cmd/write-test-dataregeneratestest-data/GeoIP-Residential-Proxy-Test.mmdbdeterministically fromsource-data/GeoIP-Residential-Proxy-Test.jsonmaxminddb.Lookup)anonymizer_confidencekey present🤖 Generated with Claude Code on behalf of @oschwald