Fix wrong epoch formatting for verbose mmdblookup#143
Merged
horgh merged 1 commit intomaxmind:masterfrom Jun 26, 2017
Merged
Conversation
(at least on 32 bit builds on Solaris Sparc). Verbose mmdblookup output before the fix: Build epoch: 1497876636 (1970-01-01 00:00:00 UTC) and after the fix: Build epoch: 1497876636 (2017-06-19 12:50:36 UTC) The original code converted *uint64_t to *time_t by casting the pointer. But that doesn't convert the referenced value and for a build where a time_t is a long of size 32bits (eg. on Solaris Sparc) probably also depending on endianess when dereferencing the casted pointer you get the wrong half of the 64 bits (=0). The fix is to cast the value and use a pointer to the casted value.
Contributor
|
Hi again @rainerjung. Thanks for the fix. Nice one! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(at least on 32 bit builds on Solaris Sparc).
Verbose mmdblookup output before the fix:
Build epoch: 1497876636 (1970-01-01 00:00:00 UTC)
and after the fix:
Build epoch: 1497876636 (2017-06-19 12:50:36 UTC)
The original code converted *uint64_t to *time_t by casting
the pointer. But that doesn't convert the referenced value
and for a build where a time_t is a long of size 32bits
(eg. on Solaris Sparc) probably also depending on endianess
when dereferencing the casted pointer you get the wrong half
of the 64 bits (=0).
The fix is to cast the value and use a pointer to the casted value.