Perform fewer memory allocations when creating the data entry list#147
Merged
Perform fewer memory allocations when creating the data entry list#147
Conversation
These do not make the output very noisy and are useful.
horgh
force-pushed
the
will2/fewer-allocations
branch
from
e5e53a8 to
c7d72c2
Compare
This is a performance optimization. Previously we would allocate memory for each node in the list one at a time with individual calls to calloc(). This change causes us to allocate 64 up front and then as more are needed, we double that each time.
horgh
force-pushed
the
will2/fewer-allocations
branch
from
c7d72c2 to
8d82d03
Compare
Member
|
This looks great! Would you also add an appropriate entry to the change log? |
This mentions the reduction in memory allocations in MMDB_get_entry_data_list().
Member
|
Closes #142 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #142, this is a hotspot. With this PR, we allocate a pool of memory up front to use for this purpose. It grows as needed.