Merged
Conversation
kurt-nj
commented
Mar 25, 2019
| uint16_t start_bit = max_depth0; | ||
|
|
||
| if (mmdb->metadata.ip_version == 6 && address_family == AF_INET) { | ||
| int mmdb_error = find_ipv4_start_node(mmdb); |
Contributor
Author
There was a problem hiding this comment.
find_ipv4_start_node already gets called from MMDB_open if ip_version == 6. It doesn't appear that this method would need to be called again.
Member
|
Thanks! This looks great. |
oschwald
added a commit
that referenced
this pull request
May 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to #24, libmaxminddb is supposed to be thread safe. This pull request adds const modifiers to the MMDB_s pointer to make it clear that the structure doesn't get modified. This allows people to use a const MMDB without needing to cast away the const.
Also removes one spot that appears to be unnecessarily modifying the MMDB_s from the ip lookup method.