Remove legacy Jekyll source files from gh-pages#262
Merged
Conversation
After the Hugo migration (STF-448), the rendered site on gh-pages is fully managed by `.github/workflows/pages.yml`. The Jekyll source files that pre-dated the migration survived `keep_files: true` on the workflow's initial run but are no longer used to render the site — GitHub Pages now sees `.nojekyll` and serves the prebuilt Hugo output. These files remain publicly fetchable today though, and `_layouts/default.html` still references a CSS host this migration is retiring. Delete them to prevent confusion and remove that lingering reference. Preserves: `doc/` (versioned API docs), `doc/latest` (symlink), `.nojekyll`, `index.html`, `css/`, and everything else pushed by the Hugo workflow. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request involves the deletion of several files related to the minFraud PHP API documentation, including the Jekyll configuration, the default HTML layout, the main API documentation Markdown file, and the associated Pygments stylesheet. These changes appear to decommission or clean up the documentation site. As there are no review comments provided, I have no feedback to provide.
horgh
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of STF-448. After the
Hugo migration landed on
main, the rendered site ongh-pagesisfully managed by
.github/workflows/pages.yml. The pre-existing Jekyllsource files survived
keep_files: trueon the workflow's initial runbut are no longer used to render the site — GitHub Pages now sees
.nojekyllat the root and serves the prebuilt Hugo output.These files remain publicly fetchable today, and
_layouts/default.htmlstill references a CSS host this migration is retiring. This PR removes
them.
Removed
_config.yml_layouts/(includingdefault.htmlwhich references the retiring host)index.mdstylesheets/pygments.cssPreserved
doc/(versioned API docs) anddoc/latest(symlink).nojekyllindex.html,css/, and everything else pushed by the Hugo workflowVerify after merge
https://maxmind.github.io/<repo>/still renders the Hugo index pagehttps://maxmind.github.io/<repo>/doc/latest/still returns 200curl -I https://maxmind.github.io/<repo>/_layouts/default.htmlreturns 404 (was 200 before)