Skip to content

Add async support#59

Merged
horgh merged 6 commits intomasterfrom
greg/async
Jul 21, 2020
Merged

Add async support#59
horgh merged 6 commits intomasterfrom
greg/async

Conversation

@oschwald
Copy link
Copy Markdown
Member

No description provided.

Comment thread HISTORY.rst Outdated
* Asyncio support has been added for web service requests. To make async
requests, use ``minfraud.AsyncClient``.
* ``minfraud.Client`` now provides a ``close()`` method and an associated
context managers to be used in ``with`` statements.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"manager" perhaps?

Comment thread minfraud/webservice.py Outdated
# pylint: disable=too-many-instance-attributes, missing-class-docstring
class BaseClient:
_account_id: str
_host: str
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this set somewhere?

@horgh horgh merged commit 1cda26e into master Jul 21, 2020
@horgh horgh deleted the greg/async branch July 21, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants