Add new /credit_card/country input#97
Merged
shadromani merged 1 commit intomainfrom Mar 8, 2022
Merged
Conversation
oschwald
force-pushed
the
greg/cc-country-input
branch
from
5fd8b7e to
7fa7463
Compare
oschwald
force-pushed
the
greg/cc-country-input
branch
from
7fa7463 to
32d44d7
Compare
shadromani
reviewed
Mar 7, 2022
Contributor
shadromani
left a comment
shadromani
left a comment
There was a problem hiding this comment.
LGTM! One minor suggestion!
| "decline_code": "invalid number" | ||
| }, | ||
| "credit_card": { | ||
| "country": "US", |
Contributor
There was a problem hiding this comment.
How about another request that contains country but no issuer ID? I think we need to verify that no exception is thrown in that case.
Member
Author
There was a problem hiding this comment.
We don't throw an exception if they provide both. Also, the change to test_validation.py would test that no exception is thrown when they only provide a valid country.
shadromani
approved these changes
Mar 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.