Add :clear to report transaction tag values (STF-190)#219
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds the :clear tag to the Minfraud::Components::Report::Transaction component, updating the documentation, the enum_accessor, and the test suite. A suggestion was made to clarify the purpose of the :clear tag in the documentation, specifically noting its use for retracting previous reports.
Comment on lines
+26
to
+27
| # This may be one of +:chargeback+, +:clear+, +:not_fraud+, | ||
| # +:spam_or_abuse+, or +:suspected_fraud+. |
There was a problem hiding this comment.
The :clear tag has a specific functional behavior (retracting a previous report) that distinguishes it from the other likelihood-based tags. Adding a brief explanation in the docstring would help users understand its purpose without needing to refer to the external API documentation.
# This may be one of +:chargeback+, +:clear+ (to retract a previous
# report), +:not_fraud+, +:spam_or_abuse+, or +:suspected_fraud+.Part of STF-190. The `clear` tag retracts a previously reported fraud report tag on a transaction, restoring its label to "unknown" (distinct from the positive `:not_fraud` signal). Backend support shipped in STF-15; this adds SDK support. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sets up `mise` for automatic Ruby provisioning, matching the pattern already in use in minfraud-api-dotnet and GeoIP2-dotnet. Uses `latest` to let contributors pick up the newest stable Ruby, mirroring the behavior of the dotnet repos. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
horgh
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:clearto theenum_accessor :tagarray onMinfraud::Components::Report::Transaction, updates the docstring(with a parenthetical clarifying that
:clearretracts a previousreport), and extends the valid-values iteration in the component spec.
Appends a bullet to the existing unreleased
v2.10.0entry inCHANGELOG.md.mise.toml(and generatedmise.lock) socontributors can
mise installto get a working Ruby toolchain. Usesruby = "latest"to match the"latest"convention used inminfraud-api-dotnet/GeoIP2-dotnet. Not STF-190 specific —separate commit for easy review.
The
cleartag retracts a previously reported fraud report on a transaction(restoring its label to "unknown", distinct from the positive
:not_fraudsignal). Backend support shipped in STF-15; this adds SDK support per STF-190.
Linear: https://linear.app/maxmind/issue/STF-190
Test plan
bundle exec rake(sandbox could not build Ruby from source dueto missing libssl-dev — relying on CI to verify)
iterates the same array.
🤖 Generated with Claude Code