Unix domain socket support #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmindlin
reviewed
Nov 3, 2022
Owner
|
Could you also please update the README to mention these additional protocols? |
maxmindlin
reviewed
Nov 3, 2022
Contributor
Author
Yes, I will update it when I have time. Please read the above reply to check for code changes. |
Contributor
Author
|
I have updated the README to mention these additional protocols, please help to merge. |
Owner
|
LGTM - thanks for the contribution! |
maxmindlin
approved these changes
Nov 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version only supports
TCPandUDP, and the code currently fails to passcargo fmt -- --checkandcargo clippy -- -D warnings. I have followed the instructions offmtandclippyand adjusted the code style to pass the cargo lint tool's checking. And added the support ofunix(unix domain stream) andunixgram(unix domain datagram) two protocols, they can work normally after testing.