chore(deps)(deps): bump golang.org/x/sys from 0.36.0 to 0.37.0 in /src/amqp-go#1
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Conversation
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
dependabot
Bot
force-pushed
the
dependabot/go_modules/src/amqp-go/golang.org/x/sys-0.37.0
branch
2 times, most recently
from
5ff5ea8 to
d3322dc
Compare
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.36.0 to 0.37.0. - [Commits](golang/sys@v0.36.0...v0.37.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-version: 0.37.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/go_modules/src/amqp-go/golang.org/x/sys-0.37.0
branch
from
d3322dc to
90d3e08
Compare
Author
|
Superseded by #9. |
dependabot
Bot
deleted the
dependabot/go_modules/src/amqp-go/golang.org/x/sys-0.37.0
branch
x0a1b
added a commit
that referenced
this pull request
Jun 24, 2026
…ypass Phase 16, Commit 2: Lock contention + config wiring. P1: Replace ds.mutex with sync.Map for queue rings (disruptor_storage.go) - Replaced global sync.RWMutex + map[string]*QueueRing with sync.Map - getQueueRing() helper: lock-free reads on publish/get/delete hot path - getOrCreateQueueRing(): double-check locking (mutex only during rare queue creation — not on every publish) - Eliminates #1 throughput limiter: all publishes across all queues no longer serialize on a single write lock - Removed dead deliveryTagCounters map (tags from broker global counter) P6: Reduce AvailableChannelBuffer 10M → 100K (config.go) - 80MB → 800KB per queue (100x memory reduction) - 1000 queues: 80GB → 800MB — enables realistic multi-queue deployments - 100K buffer at 100K msg/s = 1s headroom (sufficient for consumer reconnect) P8: Fix durable message spill bypass (disruptor_storage.go) - Durable messages (DeliveryMode=2) now also skip ring buffer when above spill threshold — they're already in WAL, entering ring buffer would overwrite unconsumed slots and force consumers onto slow WAL read path - Both durable and transient skip ring buffer when >80% full; messages retrieved from WAL on-demand when consumers need them Code review: 1 round, 0 CRITICAL, 0 MAJOR, 3 MINOR (comment fix) All tests pass with -race across all packages.
x0a1b
added a commit
that referenced
this pull request
Jun 26, 2026
CRITICAL fixes: - #1 Fanout clone: clone *Message per target queue in PublishMessage so each queue owns its own copy with its own DeliveryTag (R6 fix) - #2 PendingAck: implement in-memory sync.Map-based pending ack tracking (was all no-op stubs — multiple-ack/reject/nack broken) - #3 Nil WAL guard: guard spill path with ds.wal != nil check (was nil-pointer panic on disk failure) - #4 Wire AckCursor: call RegisterConsumerCursor/DeliverToConsumer/ AckFromConsumer/NackFromConsumer/UnregisterConsumerCursor from broker (all 7 interface methods were never called — dead code) MAJOR fixes: - #5 minAckCursor skip-ahead: sync QueueState.minAckCursor from storage AckCursor after each ACK (was only +1, stuck under out-of-order ACKs causing permanent backpressure) - #6 Duplicate ACK guard: check deliveryIndex before processing (was double-decrementing inflight counter) - #7 RejectMessage requeue: always requeue or discard (was depending on GetPendingAck which always returned not-found — requeue never executed, message orphaned) - #8 NacknowledgeMessage: same fix as RejectMessage - #9 computeDepthHighWM default: align with storage default 256K (was 64K — publishers blocked 4x too early) Cleanup: - Removed dead AdvanceMinAckCursor (passed tag=0, never called) - Set message.DeliveryTag on original pointer for caller inspection - Added SetMinAckCursor to QueueState Full test suite passes with -race across all 13 packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps golang.org/x/sys from 0.36.0 to 0.37.0.
Commits
1edeebeunix: mkall.sh: fail if docker build failedecada54unix: use slices.{Equal,Sort} in tests5e63aa5windows: export O_FILE_FLAG_* to be used in os.OpenFile on windows033906bunix: add (*CPUSet).Fill helper to enable all CPUs6be6c58windows: add FlushConsoleInputBuffer and GetNumberOfConsoleInputEvents32e2038unix: use Go 1.21+ clear built-in137f2edsys: add support for NetBSD getvfsstatDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)