Support optional Clerk auth and add local preview mode#1
Open
Support optional Clerk auth and add local preview mode#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
apps/dashboard/lib/clerk.tsandisClerkConfiguredto detect presence ofNEXT_PUBLIC_CLERK_PUBLISHABLE_KEYandCLERK_SECRET_KEYand used it across the app.RootLayoutrender a plainAppShellwhen Clerk is not configured and otherwise wrap the app inClerkProviderwithsignInUrl/signUpUrlset.TabsLayoutto only callauth()when Clerk is configured, default role toadminwhen not configured, and show a "Preview mode" badge in the header when running without Clerk.middleware.tswithproxy.tsthat conditionally appliesclerkMiddlewareonly if Clerk is configured and otherwise returnsNextResponse.next().AuthConfigNoticecomponent and updated sign-in and sign-up pages to display it when Clerk is not configured.UserMenuto render a simple "Local preview" pill when Clerk is not configured instead of usingUserButton.eslint.config.mjsand changed thelintscript inapps/dashboard/package.jsonto runeslintwith the new config followed bytsc --noEmit.turbo.jsonto include Clerk environment variables inglobalEnvso builds consider them.Testing
eslint . --config eslint.config.mjs --ext .js,.mjsandtsc --noEmit) and they completed successfully.NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY/CLERK_SECRET_KEYare absent, and that theclerkMiddlewarepath is exercised when those variables are present (manual dev verification).Codex Task