This repository was archived by the owner on Jul 27, 2025. It is now read-only.
Fixes #2100: this will fix the problem of text not visible in the modal when dark theme is set #2112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m of text not visible in dark theme inside the modals
Member
|
Thanks so much, @DSY4444! Can you add a screenshot of the result of your changes? Helps us review/approve PRs much faster. |
Contributor
Author
|
sure, @Shpigford I'll add screenshots showing difference |
Contributor
Author
|
before |
Contributor
Author
|
after 
|
Contributor
Author
|
As you can see the visibility of text changes based on theme, earlier it was not the case. |
…t-to-be-visible-in-modal Signed-off-by: Zach Gollwitzer <zach@maybe.co>
|
@DSY4444 i think some of the elements are still applying the incorrect color |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 'text-primary' inside the class, this will pick the appropriate system color based on theme